Skip to content

Commit

Permalink
Move REPL related xsbti Java to correct module
Browse files Browse the repository at this point in the history
xsbti Java classes were ported into compiler bridge, instead of the compiler interface by mistake.
Since there's not code utilizing this interface yet, this was never caught.
  • Loading branch information
eed3si9n committed Oct 9, 2017
1 parent 30c9bb4 commit e2896e1
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion build.sbt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Util._
import Dependencies._
import Scripted._
//import com.typesafe.tools.mima.core._, ProblemFilters._
import com.typesafe.tools.mima.core._, ProblemFilters._

def baseVersion = "1.1.0-SNAPSHOT"
def internalPath = file("internal")
Expand Down Expand Up @@ -387,6 +387,14 @@ lazy val compilerBridge: Project = (project in internalPath / "compiler-bridge")
publishLocal := publishLocal.dependsOn(cleanSbtBridge).value,
altPublishSettings,
mimaSettings,
mimaBinaryIssueFilters ++= Vector(
// xsbti Java interfaces must be defined in the compiler interface, not the bridge.
// Bridge implementations are compiled per Zinc, so these are safe to change.
exclude[MissingClassProblem]("xsbti.InteractiveConsoleFactory"),
exclude[MissingClassProblem]("xsbti.InteractiveConsoleResult"),
exclude[MissingClassProblem]("xsbti.InteractiveConsoleInterface"),
exclude[MissingClassProblem]("xsbti.InteractiveConsoleResponse"),
),
)

val scalaPartialVersion = Def setting (CrossVersion partialVersion scalaVersion.value)
Expand Down

0 comments on commit e2896e1

Please sign in to comment.