Notify ClassFileManager from IncOptions in Incremental.prune #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Incremental.prune` method creates a `deleteImmediately` `ClassFileManager` to prune the classfiles of invalidated sources. This means that the external `ClassFileManager` defined in `options.externalHooks` is not notified about these deletions. Changing this to use `ClassFileManager.getClassFileManager` creates a `WrappedClassFileManager`, which also uses `deleteImmediately` (unless configured otherwise by `incOptions.classfileManagerType`), and additionaly notifies the external manager from `options.externalHooks`.
This comment was marked as resolved.
This comment was marked as resolved.
dwijnand
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Incremental.prunemethod creates adeleteImmediatelyClassFileManagerto prune the classfiles of invalidated sources. This means that the externalClassFileManagerdefined inoptions.externalHooksis not notified about these deletions.Changing this to use
ClassFileManager.getClassFileManagercreates aWrappedClassFileManager, which also usesdeleteImmediately(unless configured otherwise byincOptions.classfileManagerType), and additionaly notifies the external manager fromoptions.externalHooks.Fixes #1147