Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify ClassFileManager from IncOptions in Incremental.prune #1148

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Notify ClassFileManager from IncOptions in Incremental.prune #1148

merged 1 commit into from
Nov 29, 2022

Commits on Nov 9, 2022

  1. Notify ClassFileManager from IncOptions in Incremental.prune 

    The `Incremental.prune` method creates a `deleteImmediately`
`ClassFileManager` to prune the classfiles of invalidated sources.
This means that the external `ClassFileManager` defined in
`options.externalHooks` is not notified about these deletions.

Changing this to use `ClassFileManager.getClassFileManager` creates
a `WrappedClassFileManager`, which also uses `deleteImmediately`
(unless configured otherwise by `incOptions.classfileManagerType`), and
additionaly notifies the external manager from `options.externalHooks`.
    @lrytz
    lrytz committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    69eb60b View commit details
    Browse the repository at this point in the history