Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDEs to the README #250

Closed
wants to merge 2 commits into from
Closed

Add IDEs to the README #250

wants to merge 2 commits into from

Conversation

jvican
Copy link
Member

@jvican jvican commented Mar 3, 2017

Intellij and Scala IDE also use Zinc 1.0 and should be mentioned in the
README.

README.md Outdated
@@ -1,6 +1,8 @@
Zinc
====

**This is Scala Center's fork of [Zinc][sbt/zinc].**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this change was not supposed to be added to this pull request. I'm removing this and I'll add it afterwards. I'm moving my private repository to scala center's organization before public release of blog post.

dwijnand and others added 2 commits March 3, 2017 11:51
This issue was fixed in https://github.com/sbt/zinc/pull/239/files#diff-65c95a9d18dc8a76c6182e1c6377fc65R154.

For some reason, 2.10 compiler is detecting root packages to have
symbols fields (which 2.11 do not recognise as such), so we need to
protect from them in `ExtractUsedNames` since `_root_` should definitely
not be registered as a name, because it's present in any Scala source
file.
@jvican
Copy link
Member Author

jvican commented Mar 3, 2017

Closing this PR, I messed up branches. Easiest option.

@jvican jvican closed this Mar 3, 2017
cunei pushed a commit to cunei/zinc that referenced this pull request Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants