Fix #930: Report original problems in SourceInfos #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I do something to validate this against sbt? |
|
@adpi2 Thanks for the fix. @rtimush wrote in sbt/sbt#5892 (comment):
It would be good if you could confirm that this patch would address sbt/sbt#5892 by locally publishing zinc. I often use the following to bind SNAPSHOT Zinc against sbt to locally check: |
|
I checked sbt/sbt#5892 with this PR and my test (sbt/sbt@develop...rtimush:warnings-test) passed. |
eed3si9n
approved these changes
Oct 8, 2020
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 9, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
mkurz
added a commit
to mkurz/playframework
that referenced
this pull request
Mar 10, 2021
… mapping is only done for logging Starting with sbt 1.4.1, when a compilation error occurs, the Position of a Problem (which is contained within the Incomplete) will no longer refer to the mapped source file (e.g. until sbt 1.4.0 the Position would refer to "conf/routes" when a compilation error actually happened in "target/scala-2.13/routes/main/router/Routes.scala"). That's caused by sbt/zinc#931: The file causing the compilation error is not transformed via the sourcePositionMappers config anymore before adding it to "allProblems", the field that eventually gets used by the Incomplete. (The transformation still takes place to show the mapped source file in the logs) Play however needs to know the mapped source file to display it in it's error pages for a nice dev experience. So the solution is that Play itself will try to transform the source file to the mapped file by running it "through" sourcePositionMappers:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
LoggedReporter.allProblemsreturn original problems so that theAnalysisCallbackcan link each position to the correspondingVirtualFile