Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client aenter connect error lock release #245

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

vvanglro
Copy link
Contributor

fix: #244

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #245 (1058b6d) into main (40d4f56) will increase coverage by 0.5%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #245     +/-   ##
=======================================
+ Coverage   84.1%   84.7%   +0.5%     
=======================================
  Files          4       4             
  Lines        468     472      +4     
  Branches      87      87             
=======================================
+ Hits         394     400      +6     
+ Misses        47      45      -2     
  Partials      27      27             
Files Changed Coverage Δ
aiomqtt/client.py 83.3% <100.0%> (+0.6%) ⬆️

@vvanglro
Copy link
Contributor Author

vvanglro commented Aug 22, 2023

ci relevant: snok/install-poetry#94

aiomqtt/client.py Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
@empicano
Copy link
Collaborator

Hi there,

Great that you put work into this, thank you! 😎 I believe the reason that the tests are failing is that the poetry dropped support for Python 3.7 in 1.6.0 rather than the issue you linked. See also your first commit, where all those workflows that use Python 3.7 fail, but not the others.

Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.

Your PR looks good to me otherwise 🙂

@vvanglro
Copy link
Contributor Author

Python 3.7 reached its end of life, so I think we can drop it anyways. I opened PR #246 to do that.

When your PR is merged, I will merge it once.

@frederikaalund
Copy link
Member

Looks good to me as well. 👍 I just reviewed #246 as well.

@empicano empicano merged commit 1f0f0b3 into sbtinstruments:main Aug 23, 2023
11 checks passed
@empicano
Copy link
Collaborator

Thanks for another great contribution to aiomqtt, @vvanglro! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconnection example throws "Does not support reentrant"
3 participants