Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #246

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Drop support for Python 3.7 #246

merged 2 commits into from
Aug 23, 2023

Conversation

empicano
Copy link
Collaborator

Python 3.7 has reached its end-of-life. Poetry dropped support in 1.6.0 so our test workflow is breaking. @vvanglro made an ad-hoc fix in #245 for that, but I think we're good to go to drop it as well in the next release.

Is there anything we can simplify in the code with this step that I missed?

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #246 (48cc226) into main (b9ce2bf) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #246   +/-   ##
=====================================
  Coverage   84.1%   84.1%           
=====================================
  Files          4       4           
  Lines        468     468           
  Branches      87      87           
=====================================
  Hits         394     394           
  Misses        47      47           
  Partials      27      27           
Files Changed Coverage Δ
aiomqtt/client.py 82.7% <100.0%> (ø)

Copy link
Member

@frederikaalund frederikaalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to drop Python 3.7 support! I think that we've done our maintenance duty in that part (most other libraries dropped it already). 😄

Besides the positional-only arguments, we also got the walrus operator (:=) in python 3.8.later. There may be a use case for that somewhere but it's not really worth the refactor IMHO. :)

See my review for details. Let me know if you have any questions! 👍

aiomqtt/client.py Show resolved Hide resolved
aiomqtt/client.py Show resolved Hide resolved
@empicano empicano merged commit 40d4f56 into main Aug 23, 2023
12 checks passed
@empicano empicano deleted the drop37 branch August 23, 2023 13:10
@JonathanPlasse
Copy link
Collaborator

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants