Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #246

Merged
merged 2 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,14 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version:
# Add "pypy-3.8", "pypy-3.9" again at some point
["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
include:
- os: macos-latest
python-version: "3.7"
python-version: "3.8"
- os: macos-latest
python-version: "3.11"
- os: windows-latest
python-version: "3.7"
python-version: "3.8"
- os: windows-latest
python-version: "3.11"
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ aiomqtt combines the stability of the time-proven [paho-mqtt](https://github.com

## Installation

aiomqtt can be installed via `pip install aiomqtt`. It requires Python `3.7+` to run. The only dependency is [paho-mqtt](https://github.com/eclipse/paho.mqtt.python).
aiomqtt can be installed via `pip install aiomqtt`. It requires Python `3.8+` to run. The only dependency is [paho-mqtt](https://github.com/eclipse/paho.mqtt.python).

If you can't wait for the latest version and want to install directly from GitHub, use:

Expand Down
5 changes: 4 additions & 1 deletion aiomqtt/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def _outgoing_call(
method: Callable[Concatenate[ClientT, P], Coroutine[Any, Any, T]]
) -> Callable[Concatenate[ClientT, P], Coroutine[Any, Any, T]]:
@functools.wraps(method)
async def decorated(self: ClientT, *args: P.args, **kwargs: P.kwargs) -> T:
async def decorated(self: ClientT, /, *args: P.args, **kwargs: P.kwargs) -> T:
empicano marked this conversation as resolved.
Show resolved Hide resolved
if not self._outgoing_calls_sem:
return await method(self, *args, **kwargs)

Expand Down Expand Up @@ -549,6 +549,7 @@ def _force_disconnect(self) -> None:
@_outgoing_call
async def subscribe( # noqa: PLR0913
self,
/,
frederikaalund marked this conversation as resolved.
Show resolved Hide resolved
topic: SubscribeTopic,
qos: int = 0,
options: mqtt.SubscribeOptions | None = None,
Expand Down Expand Up @@ -589,6 +590,7 @@ async def subscribe( # noqa: PLR0913
@_outgoing_call
async def unsubscribe(
self,
/,
topic: str | list[str],
properties: Properties | None = None,
*args: Any,
Expand Down Expand Up @@ -620,6 +622,7 @@ async def unsubscribe(
@_outgoing_call
async def publish( # noqa: PLR0913
self,
/,
topic: str,
payload: PayloadType = None,
qos: int = 0,
Expand Down
Loading
Loading