Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: decoupling the solidity-coverage from solc version? #91

Closed
travs opened this issue Aug 16, 2017 · 3 comments
Closed

Question: decoupling the solidity-coverage from solc version? #91

travs opened this issue Aug 16, 2017 · 3 comments

Comments

@travs
Copy link

travs commented Aug 16, 2017

What do you think about allowing the user to specify the solc version being used?

The use-case would be a compiler regression that affects contracts, such as this one.

Of course, one can always downgrade/pin the solidity-coverage version, but features developed since then will be unavailable without getting the offending solc version as well.

One way to achieve this without dealing with different NPM packages may be using legacy solc versions, and specifying it in the .solcover.js file (though I have not tried this).

Anyway, let me know if this makes any sense to you :)

@travs travs changed the title Question: what do you think about decoupling the package from solc version? Question: decoupling the solidity-coverage from solc version? Aug 16, 2017
@area
Copy link
Contributor

area commented Aug 16, 2017

I agree that this would be a useful piece of functionality, but I don't think the responsibility lies with us to provide it. The solc version in our dependencies is a development dependency, and is only required for running the tests of solidity-coverage itself. During tests, the version of solc being used depends on how you're running your tests; for most users of solidity-coverage, I would expect that to be truffle, which seems unlikely to support this in the near term.

@travs
Copy link
Author

travs commented Aug 16, 2017

@area
Ah, I misunderstood how solidity-coverage operates, but it makes more sense now.
I have had a similar issue with truffle, and you are right: this is actually more related to the test runner.

I will close it since it does not depend directly on this project.
Thanks for the reply 👍

@travs travs closed this as completed Aug 16, 2017
@celeduc
Copy link
Contributor

celeduc commented Dec 23, 2018

This is now possible in truffle v0.5.x.

in truffle config:

module.exports = {
  compilers: {
    solc: {
      version: <string> // A version or constraint - Ex. "^0.5.0"
    }
  }
}

https://truffleframework.com/docs/truffle/reference/configuration#solc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants