Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy all directories when setting up coverageEnv #44

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

area
Copy link
Contributor

@area area commented Jun 26, 2017

The exception is node_modules, which must have copyNodeModules
set to true in .solcover.js in order to be included.

Fixes #39. I'm not sure what you want to see in terms of #43, though.

EDIT: I seem to have clobbered a load of trailing spaces in this PR too. Maybe it's best to just bin this PR 馃槢 .

The exception is `node_modules`, which must have copyNodeModules
set to `true` in .solcover.js in order to be included.
@codecov-io
Copy link

codecov-io commented Jun 26, 2017

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           6        6           
  Lines         329      329           
  Branches       78       78           
=======================================
  Hits          321      321           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3d95e31...5bf8f93. Read the comment docs.

@cgewecke
Copy link
Member

@area This is good. I think this should go in. The only thing that occurs to me is that there might be a couple other folder's we could habitually exclude - coverage and possibly build. Not sure they make much of difference to setup speed though so not v. important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants