Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardhat to peerDependencies #722

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Add hardhat to peerDependencies #722

merged 2 commits into from
Sep 5, 2022

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented May 30, 2022

This fixes a compatibility issue with Yarn strict pnpMode, as solidity-coverage calls require() on hardhat.

This fixes a compatibility issue with Yarn strict pnpMode, as
solidity-coverage calls require() on hardhat.
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #722 (4d11197) into master (bc7d076) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          19       19           
  Lines        1051     1051           
=======================================
  Hits         1008     1008           
  Misses         43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7d076...4d11197. Read the comment docs.

@kevinji
Copy link
Contributor Author

kevinji commented Aug 23, 2022

@cgewecke do you mind reviewing this?

@cgewecke
Copy link
Member

cgewecke commented Sep 5, 2022

Thanks, looks good!

@cgewecke cgewecke merged commit 4c63612 into sc-forks:master Sep 5, 2022
@kevinji kevinji deleted the add-hardhat-peer-dep branch September 7, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants