Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [txHash] page bug & backmerge main #19

Merged
merged 4 commits into from
May 3, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented May 2, 2024

Fixes #20

Actually, while merging at #12 and #15 (I tried fixing but again added it wrong path) so TransactionComp was added at wrong path :(, just put it in right place.

^ I think we should probably setup a CI which runs yarn build and then yarn next:check-types & yarn lint on generated repo. Will create an issue for it.

Also tested it, here are deployments links :

Hardhat : https://test-hh-latest.vercel.app/
Foundry : https://test-foundry-latest41.vercel.app/

NOTE: We should do "Merge with commit" instead of "Squash and Merge"

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@technophile-04
Copy link
Collaborator Author

Thanks @rin-st, Merging this 🙌

@technophile-04 technophile-04 merged commit cc3286e into main May 3, 2024
@technophile-04 technophile-04 deleted the backmerge-upstream-main1 branch May 3, 2024 06:20
@carletex
Copy link
Member

carletex commented May 3, 2024

I think we should probably setup a CI which runs yarn build and then yarn next:check-types & yarn lint on generated repo. Will create an issue for it.

Yes, let's do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Fresh foundry project using CLI failing in Vercel build
4 participants