-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize displaying of address and follow ERC-55 #734
Standardize displaying of address and follow ERC-55 #734
Conversation
TYSM for tackling this @tjayrush to add consistency to our shortened addresses 🔥 Added a couple of issues to check at my review 🙌 |
packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/AddressInfoDropdown.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tjayrush and @Pabl0cks for review 🙌
Just pushed a small commit to show same format address at 053ef25 by using viem's getAddress
which also seems a convention followed by metamask and other wallet 🙌 . I remember us discussing about this
Before | After |
---|---|
check out the 4th "F" in both image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me! GJ @tjayrush and @technophile-04 !
Just pushed a small commit to show same format address at 053ef25 by using viem's getAddress which also seems a convention followed by metamask and other wallet 🙌 . I remember us discussing about this
Really good one! 🔥
Description
Closes the issue by make both displays of the address 0x1234...1234
Additional Information
Related Issues
_Closes #733
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: trueblocks.eth