Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test harness and two tests #341

Merged
merged 4 commits into from
Apr 3, 2019
Merged

add test harness and two tests #341

merged 4 commits into from
Apr 3, 2019

Conversation

mjhea0
Copy link
Contributor

@mjhea0 mjhea0 commented Mar 22, 2019

No description provided.

This was referenced Mar 22, 2019
Closed
Closed
@mjhea0 mjhea0 requested a review from jtauber March 22, 2019 19:20
@jtauber jtauber requested a review from paltman March 26, 2019 14:58
jtauber
jtauber approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@jtauber jtauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I've added Patrick for an extra Vue.js review.

@mjhea0 mjhea0 changed the title add test hardness and two tests add test harness and two tests Mar 30, 2019
paltman
paltman approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@paltman paltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

@mjhea0 mjhea0 merged commit d4784fd into dev Apr 3, 2019
@mjhea0 mjhea0 deleted the feature/add-vue-test-utils branch April 3, 2019 18:01
@jacobwegner jacobwegner mentioned this pull request Apr 30, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paltman paltman paltman approved these changes

@jtauber jtauber jtauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjhea0 @paltman @jtauber