Watched state management refactor #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elgatito
commented
Apr 7, 2017
elgatito
commented
- Processing Watched progress state in torrentfs Close() to be sure we save progress for any played item.
- Removed Player.onStop notification processor as Kodi seems to send sometimes wrong IDs (depends on ListItem parameters, while we surely know what we play).
- Moved all that to separate Library package, moved Infolabels also there
- When Item is started from Quasar - it's Watching state gets synchronized with Kodi library.
elgatito
force-pushed
the
watched_refactor
branch
from
7837098
to
42db57e
Compare
|
All additions are using spaces for indentation... |
scakemyer
reviewed
Apr 9, 2017
bittorrent/service.go
Outdated
| "regexp" | ||
| "strconv" | ||
| "strings" | ||
| "time" |
There was a problem hiding this comment.
Please follow the visual order for imports
scakemyer
reviewed
Apr 9, 2017
bittorrent/service.go
Outdated
| "github.com/scakemyer/quasar/config" | ||
| "github.com/scakemyer/quasar/diskusage" |
There was a problem hiding this comment.
Those imports were ordered properly
scakemyer
reviewed
Apr 9, 2017
bittorrent/service.go
Outdated
| libtorrent.AlertErrorNotification)) | ||
| libtorrent.AlertStatusNotification| | ||
| libtorrent.AlertStorageNotification| | ||
| libtorrent.AlertErrorNotification)) |
There was a problem hiding this comment.
Indentation and space before | was fine here
scakemyer
reviewed
Apr 9, 2017
bittorrent/service.go
Outdated
| case libtorrent.ExternalIpAlertAlertType: | ||
| splitMessage := strings.Split(alertMessage, ":") | ||
| splitIP := strings.Split(splitMessage[len(splitMessage)-1], ".") | ||
| alertMessage = strings.Join(splitMessage[:len(splitMessage)-1], ":") + splitIP[0] + ".XX.XX.XX" |
scakemyer
reviewed
Apr 9, 2017
bittorrent/torrentfs.go
Outdated
| "sync" | ||
| "time" | ||
| "unsafe" | ||
| "encoding/hex" |
elgatito
force-pushed
the
watched_refactor
branch
2 times, most recently
from
5b6fff2
to
dab905d
Compare
|
Commit updated |
scakemyer
reviewed
Apr 11, 2017
api/watcher.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| watcherLog = logging.MustGetLogger("watcher") |
There was a problem hiding this comment.
Single space after watcherLog here
scakemyer
reviewed
Apr 11, 2017
bittorrent/service.go
Outdated
| @@ -313,7 +319,7 @@ func (s *BTService) configure() { | |||
| settings.SetBool(libtorrent.SettingByName("use_read_cache"), true) | |||
| settings.SetBool(libtorrent.SettingByName("coalesce_reads"), true) | |||
| settings.SetBool(libtorrent.SettingByName("coalesce_writes"), true) | |||
| settings.SetInt(libtorrent.SettingByName("max_queued_disk_bytes"), 10 * 1024 * 1024) | |||
| settings.SetInt(libtorrent.SettingByName("max_queued_disk_bytes"), 10*1024*1024) | |||
There was a problem hiding this comment.
Bring back those shpaces pleagzes
scakemyer
reviewed
Apr 11, 2017
bittorrent/torrentfs.go
Outdated
| "path/filepath" | ||
| "sync" | ||
| "time" | ||
| "unsafe" |
There was a problem hiding this comment.
Import order was fine here, encoding/hex would go just before path/filepath and that's it
elgatito
force-pushed
the
watched_refactor
branch
from
dab905d
to
37cac48
Compare
|
Updated with fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.