Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to be compatible with Scala IDE master #213

Merged
merged 1 commit into from
Jul 23, 2014
Merged

Updates to be compatible with Scala IDE master #213

merged 1 commit into from
Jul 23, 2014

Conversation

skyluc
Copy link
Member

@skyluc skyluc commented Jul 8, 2014

Update to latest version of plugin-profiles to use Scala 2.11.1
Add direct dependency to scala-xml and scala-parser-combinators

@ghprb-bot
Copy link

Test FAILed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/19/

@dragos
Copy link
Member

dragos commented Jul 8, 2014

LGTM

@huitseeker
Copy link
Member

retest this please

@ghprb-bot
Copy link

Test FAILed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/20/

@huitseeker
Copy link
Member

retest this please

@ghprb-bot
Copy link

Test FAILed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/21/

huitseeker added a commit to huitseeker/scala-worksheet that referenced this pull request Jul 15, 2014
@huitseeker
Update for the upcoming plugin-profiles 1.0.5
04016da 
Similar version bumps are expected to be added to
scala-ide/scala-ide-play2#213
scala-ide/scala-search#90
This was referenced Jul 15, 2014
Merged
Open
Updates to be compatible with Scala IDE master
87a2628 
Update to latest version of plugin-profiles to use Scala 2.11.1
Add direct dependency to scala-xml and scala-parser-combinators
@ghprb-bot
Copy link

Test FAILed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/22/

@huitseeker
Copy link
Member

retest this please

@ghprb-bot
Copy link

Test FAILed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/23/

@huitseeker
Copy link
Member

this hits the corrupt eclipse binaries error. It seems hardly worth it to add -Dtycho.disableP2Mirrors=true to https://github.com/scala-ide/jenkins-scripts just to see the correct error ...
Should we merge this and then let @dragos point us to his work on 2.11.x, and then work on that to get a successful build ?

@huitseeker huitseeker mentioned this pull request Jul 16, 2014
Merged
@huitseeker
Copy link
Member

Included & integrated in #216

@huitseeker
Copy link
Member

retest this please

@ghprb-bot
Copy link

Test PASSed.
Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-play-validator/32/

@huitseeker
Copy link
Member

LGTM, too.

huitseeker added a commit that referenced this pull request Jul 23, 2014
@huitseeker
Merge pull request #213 from skyluc/issue/sync-scala-ide-master
52f3a53 
Updates to be compatible with Scala IDE master
@huitseeker huitseeker merged commit 52f3a53 into scala-ide:master Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skyluc @ghprb-bot @dragos @huitseeker