Add a cleanUp argument to the FlakyTest.retry combinator
#566
Conversation
| @@ -89,10 +92,11 @@ class JUnit4TestFinderTest { | |||
| } | |||
|
|
|||
| runnableJUnitTestClassesIn(cu) matches Set("MyTest") | |||
| cu.delete(true, null) | |||
There was a problem hiding this comment.
why do you delete it here as well?
There was a problem hiding this comment.
ehm... some left-over :-) Good catch!
|
I'd take the opportunity to fix also the typo ( |
|
Test PASSed. |
|
Test PASSed. |
|
@dragos Good to merge? |
|
Alright, I'm going ahead with this as I don't want the scala-ide-pr-validator job to keep failing. |
|
Actually, this is all wrong, I need to side-effect the |
|
Alright, I'm going to rework this, the side-effect aren't making the logic very clear. |
|
Test FAILed. |
As evinced by the recent failures of the `pr-scala-integrate-ide` job, before re-running a test we need to make sure that we clean-up any side-effect created by the previous test run.
|
Here it is: more verbose, but correct and somewhat easier to maintain. |
|
Test PASSed. |
|
I'm merging this - it's important we get a handle on the scala-ide-pr-validator failures. |
Add a `cleanUp` argument to the `FlakyTest.retry` combinator
|
Cool, thanks for the quick reaction! |
As evinced by the recent failures of the
pr-scala-integrate-idejob, beforere-running a test we need to make sure that we clean-up any side-effect created
by the previous test run.