This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
Consider local imports when calculating dependencies of Scala code #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating required imports, we filter out all dependencies that are children of the tree that uses these imports. Until now this parent child relationship was checked by looking at the associated tree positions only. This could lead to false positives for trees from different files.
mlangc
force-pushed
the
move-class-and-special-chars-1002511
branch
from
1e0a013
to
b47f800
Compare
Until now, local imports where not considered when calculating dependencies of Scala code. This led to bugs like [Ticket #1002511](https://www.assembla.com/spaces/scala-ide/tickets/1002511). This patch attempts to track and handle local imports properly. Fixes #1002511
Fixes #1002512
mlangc
force-pushed
the
move-class-and-special-chars-1002511
branch
from
e733e68
to
39ac289
Compare
|
Refer to this link for build results (access rights to CI server needed): https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-refactoring-validator/83/ |
|
Looking forward to the next "attempts" :-) Thank you very much! |
misto
added a commit
that referenced
this pull request
Aug 10, 2015
Consider local imports when calculating dependencies of Scala code
|
Cool, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my first attempt to handle local imports properly when calculating dependencies. More details can be found in the commit messages/comments.
Fixes #1002511
Fixes #1002512