PhantomJSEnv does not properly escape JS code in webpage

[gzm0]

The following code will fail:

console.log("<script></script>");

[gzm0]

Discovered while debugging #2322.

[gzm0]

This is a hard problem:

PhantomJS seems to correctly interpret everything between <script> tags as CDATA, so simply escaping the tag doesn't work. Of course a closing </script> tag can only appear in a literal string, so usually the solution is to do:

console.log("<script></sc" + "ript>");

However, this is hard to back-fit on code (without parsing it) because JS has two types of quotes.

An easy fix would be to just write stuff to temp files and include it, completely mitigating the escaping issue. However, this wont work trivially for runner code, since we need to wrap it in an onload handler (see writeCodeLauncher).

An option would be to wrap it in a magic function, write it to a file, include the file via script tag and register the onload handler on the magic function. But that seems very ugly.