Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @JSExportNamed #2442

Closed
sjrd opened this issue Jun 4, 2016 · 0 comments
Closed

Deprecate @JSExportNamed #2442

sjrd opened this issue Jun 4, 2016 · 0 comments
Assignees
Labels
language Affects language semantics.
Milestone

Comments

@sjrd
Copy link
Member

sjrd commented Jun 4, 2016

@JSExportNamed has funny semantics, and I find it very fragile in terms of language design. Their signature significantly differ on the Scala and JavaScript sides. It is also very partial, as it only supports the case where all parameters are passed in one config object (so no way for one param to be positional and the others to be named, for example).

It also seems not to be used. Google reports 0 use of @JSExportNamed, while GitHub reports 2 uses:

The ratio benefit/cost seems to be extremely low for this feature.

I suggest we deprecate it, and remove it in 1.0.0. Any opposition?

@sjrd sjrd added the language Affects language semantics. label Jun 4, 2016
@sjrd sjrd added this to the v0.6.11 milestone Jul 2, 2016
@sjrd sjrd changed the title Deprecate @JSExportNamed? Deprecate @JSExportNamed Jul 6, 2016
sjrd added a commit to sjrd/scala-js that referenced this issue Jul 6, 2016
@sjrd sjrd self-assigned this Jul 6, 2016
nicolasstucki added a commit that referenced this issue Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language Affects language semantics.
Projects
None yet
Development

No branches or pull requests

1 participant