Fix #2442: Deprecate @JSExportNamed. #2509
Conversation
| | ^ | ||
| |newSource1.scala:4: warning: class JSExportNamed in package annotation is deprecated: Use @JSExport with an explicit option bag instead. See the Scaladoc for more details. | ||
| | @JSExportNamed | ||
| | ^ |
There was a problem hiding this comment.
The duplicate warning is due to a weird interaction with PreJSExports, which creates an export bridge with the same annotation. Apparently deprecation warnings are handled later in the pipeline, and so the deprecation is reported twice.
TBH, I don't care ^^
|
Review by @nicolasstucki |
|
LGTM |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3262/ |
|
You got some new fatal warnings |
sjrd
force-pushed
the
deprecate-jsexportnamed
branch
from
1749acb
to
58050c7
Compare
sjrd
changed the title
|
Updated. |
| """ | ||
| @JSExportAll | ||
| class A { | ||
| @JSExportNamed("apply") | ||
| @JSExport("foo") | ||
| def apply(): Int = 1 | ||
| } | ||
| """ hasWarns | ||
| """ containsWarns | ||
| """ | ||
| |newSource1.scala:7: warning: Member cannot be exported to function application. It is available under the name apply instead. Add @JSExport("apply") to silence this warning. This will be enforced in 1.0. | ||
| | def apply(): Int = 1 |
There was a problem hiding this comment.
This part changed since the last review.
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3265/ |
|
LGTM |
No description provided.