Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayComparisonFailure calls into a constructor not available on JDK 6 nor our implem #3154

Closed
sjrd opened this issue Oct 16, 2017 · 0 comments
Closed

ArrayComparisonFailure calls into a constructor not available on JDK 6 nor our implem #3154

sjrd opened this issue Oct 16, 2017 · 0 comments
Assignees
@sjrd
Labels
bug Confirmed bug. Needs to be fixed.
Milestone
v0.6.21

Comments

@sjrd
Copy link
Member

sjrd commented Oct 16, 2017

It calls AssertionError(String, Throwable), which is not available on JDK 6, nor in our implementation.

This causes 2 issues:

  • On JDK 7+, linking errors if we attempt to merge to 1.x
  • On JDK 6, auto-tupling kicks in and the wrong constructor is called
@sjrd sjrd added the bug Confirmed bug. Needs to be fixed. label Oct 16, 2017
@sjrd sjrd added this to the v0.6.21 milestone Oct 16, 2017
@sjrd sjrd self-assigned this Oct 16, 2017
gzm0 added a commit that referenced this issue Oct 16, 2017
@gzm0
Merge pull request #3156 from sjrd/fix-arraycomparisonfailure-super-call
b48646b 
Fix #3154: Avoid calling `AssertionError(String, Throwable)`.
@sjrd sjrd closed this as completed in 9428b68 Oct 17, 2017
sjrd added a commit to sjrd/scala-js that referenced this issue Dec 20, 2017
@sjrd
Revert "Fix scala-js#3154: Avoid calling `AssertionError(String, Thro…
f6fb820 
…wable)`."

This reverts commit 9428b68.

That commit was avoiding a constructor not available on JDK6. Now
that we only build on JDK8+, we can use the `(String, Throwable)`
constructor, which is cleaner.
@sjrd sjrd mentioned this issue Apr 10, 2018
Merged
sjrd added a commit to sjrd/scala-js that referenced this issue Apr 27, 2019
@sjrd
[no-master] Revert "Fix scala-js#3154: Avoid calling `AssertionError(…
bf5746c 
…String, Throwable)`."

This reverts commit 9428b68.

That commit was avoiding a constructor not available on JDK6. Now
that we only build on JDK8+, we can use the `(String, Throwable)`
constructor, which is cleaner.

(cherry picked from commit f6fb820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjrd sjrd

Labels
bug Confirmed bug. Needs to be fixed.
Projects
None yet
Milestone
v0.6.21
Development

No branches or pull requests
1 participant
@sjrd