Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FewestModules can result in filenames that are greater than 255 Characters #4499

Closed
dispalt opened this issue Jun 3, 2021 · 1 comment · Fixed by #4501
Closed

FewestModules can result in filenames that are greater than 255 Characters #4499

dispalt opened this issue Jun 3, 2021 · 1 comment · Fixed by #4501
Assignees
Labels
bug Confirmed bug. Needs to be fixed.
Milestone

Comments

@dispalt
Copy link

dispalt commented Jun 3, 2021

So I have a private repository where I attempted to break a bunch of scalajs code into modules. Alot of those modules reference the same code, so it creates filenames longer than 255 characters which basically no filesystem supports. I can't share the code but I do feel like someone on the maintainer team would understand how this might happen. So I switched to smallest modules and the problem went away.

Happy to attempt to put something together but figured I'd file the issue first.

@gzm0
Copy link
Contributor

gzm0 commented Jun 3, 2021

Yeah... The problematic function is here:

private def buildModuleIDs(publicIDsUnordered: Iterable[ModuleID],

For internal modules we can pretty much chose whatever ID we want, as long as it is somewhat stable (same code should go into same module ID).

I chose this ID pattern so it's easy to understand the origin. Maybe we need to switch to less human readable IDs.

@gzm0 gzm0 added the bug Confirmed bug. Needs to be fixed. label Jun 3, 2021
@gzm0 gzm0 self-assigned this Jun 5, 2021
gzm0 added a commit to gzm0/scala-js that referenced this issue Jun 5, 2021
gzm0 added a commit to gzm0/scala-js that referenced this issue Jun 5, 2021
@gzm0 gzm0 linked a pull request Jun 5, 2021 that will close this issue
gzm0 added a commit to gzm0/scala-js that referenced this issue Jun 6, 2021
@sjrd sjrd added this to the v1.6.0 milestone Jun 7, 2021
gzm0 added a commit to gzm0/scala-js that referenced this issue Jun 7, 2021
@sjrd sjrd closed this as completed in #4501 Jun 7, 2021
sjrd added a commit that referenced this issue Jun 7, 2021
Fix #4499: Shorten internal module IDs in FewestModules mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug. Needs to be fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants