Fix #4499: Shorten internal module IDs in FewestModules mode #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
force-pushed
the
shorter-internal-modules
branch
from
12bc79b
to
dcaf6fe
Compare
gzm0
force-pushed
the
shorter-internal-modules
branch
from
dcaf6fe
to
5dd5e5e
Compare
sjrd
requested changes
Jun 7, 2021
Comment on lines
36
to
40
| val classDefs = Seq( | ||
| mainTestClassDef({ | ||
| consoleLog(str("Hello World!")) | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| val classDefs = Seq( | |
| mainTestClassDef({ | |
| consoleLog(str("Hello World!")) | |
| }) | |
| ) | |
| val classDefs = Seq( | |
| mainTestClassDef({ | |
| consoleLog(str("Hello World!")) | |
| }) | |
| ) |
Comment on lines
42
to
46
| val expectedFiles = Set( | ||
| "internal-0.js", // public module | ||
| "internal-1.js", // public module | ||
| "internal-2.js" // internal module, avoiding internal-0 and internal-1. | ||
| ) |
There was a problem hiding this comment.
Suggested change
| val expectedFiles = Set( | |
| "internal-0.js", // public module | |
| "internal-1.js", // public module | |
| "internal-2.js" // internal module, avoiding internal-0 and internal-1. | |
| ) | |
| val expectedFiles = Set( | |
| "internal-0.js", // public module | |
| "internal-1.js", // public module | |
| "internal-2.js" // internal module, avoiding internal-0 and internal-1. | |
| ) |
gzm0
force-pushed
the
shorter-internal-modules
branch
from
5dd5e5e
to
15026b2
Compare
|
Updated. |
sjrd
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.