Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2471: java.io.BufferedReader should close its underlying Reader #2472

Closed
wants to merge 1 commit into from
Closed

Fix #2471: java.io.BufferedReader should close its underlying Reader #2472

wants to merge 1 commit into from

Conversation

alexandru
Copy link

@alexandru alexandru commented Jun 15, 2016 •
edited

Fix for issue #2471. See the JavaDoc for BufferedReader.close. The contract is this:

  • it is idempotent (check)
  • it should release any associated resources

The current implementation of BufferedReader doesn't release the underlying Reader on close().

@scala-jenkins
Copy link

Can one of the admins verify this patch?

@nicolasstucki
Copy link
Contributor

Could you add some tests for that change.

@alexandru
Copy link
Author

@nicolasstucki where are the tests located?

@sjrd
Copy link
Member

sjrd commented Jun 16, 2016

https://github.com/scala-js/scala-js/blob/master/test-suite/shared/src/test/scala/org/scalajs/testsuite/javalib/io/ReadersTest.scala

@sjrd sjrd mentioned this pull request Jul 14, 2016
Merged
@sjrd
Copy link
Member

sjrd commented Jul 15, 2016

Superseded by #2533.

@sjrd sjrd closed this Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexandru @scala-jenkins @nicolasstucki @sjrd