Small javalib changes #2533
Merged
Small javalib changes #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of fixing `close()`, this fixes the behavior of `skip()` on a closed stream, which should also throw an `IOException`.
|
Review by @nicolasstucki |
|
Refer to this link for build results (access rights to CI server needed): https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3306/ |
| val src = new AnyRef | ||
| val e = new EventObject(src) | ||
| assertSame(src, e.getSource) | ||
| } |
There was a problem hiding this comment.
As source is a protected var I would check that we can modify it from a class that extends from EventObject. Mainly to check that the JVM behaves the same way.
There was a problem hiding this comment.
See the commented test down below.
|
That is all. |
This was referenced Jul 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2386 and #2472, which were lacking follow up from their authors.