Fix #4560: Explicitly redirect JS envs outputs to System.{out,err}. #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,err}.
When running in server mode, sbt installs alternative streams for
`System.out` and `System.err`. However, those alternatives are not
guaranteed to be used when launching JSEnvs with `inheritOut` and
`inheritErr` set to `true`. In particular, a JSEnv that spawns
separate processes with the inheritIO mode will bypass
redirections set up with `System.set{Out,Err}`.
We now explicitly redirect the outputs of JS envs to `System.out`
and `System.err`, so that they always take the alternative streams
set up by sbt into account.
gzm0
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in server mode, sbt installs alternative streams for
System.outandSystem.err. However, those alternatives are not guaranteed to be used when launching JSEnvs withinheritOutandinheritErrset totrue. In particular, a JSEnv that spawns separate processes with the inheritIO mode will bypass redirections set up withSystem.set{Out,Err}.We now explicitly redirect the outputs of JS envs to
System.outandSystem.err, so that they always take the alternative streams set up by sbt into account.Resubmission of #4580 with a squashed commit.