Exclude files from Scala's library-aux to prepare for 2.13.14.
#4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Scala 2.13.14, the stdlib's source jar contains the files of their `library-aux` directory. These files are not meant to be processed by the regular compiler (only by Scaladoc). We must therefore exclude them from the compilation of the scalalib. In the process, we remove the exclusion of `/scala/util/parsing/` which has been dead code since we dropped support for Scala 2.11.
|
Upstream change: scala/scala#10714 |
gzm0
approved these changes
Apr 28, 2024
| * meant to be compiled. They are part of the source jar since Scala 2.13.14. | ||
| */ | ||
| val excludeFiles = | ||
| Set("Any.scala", "AnyRef.scala", "Nothing.scala", "Null.scala", "Singleton.scala") |
There was a problem hiding this comment.
I'm not so happy about this verbatim list. But I guess it is highly unlikely that it changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Scala 2.13.14, the stdlib's source jar contains the files of their
library-auxdirectory. These files are not meant to be processed by the regular compiler (only by Scaladoc). We must therefore exclude them from the compilation of the scalalib.In the process, we remove the exclusion of
/scala/util/parsing/which has been dead code since we dropped support for Scala 2.11.Locally tested with the "RC" 2.13.14-bin-a527019.