Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include library-aux sources in library sources jar #10714

Merged
merged 1 commit into from Apr 8, 2024

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Mar 14, 2024

@lrytz lrytz added this to the 2.13.14 milestone Mar 14, 2024
@lrytz lrytz requested a review from SethTisue March 14, 2024 14:33
@SethTisue
Copy link
Member

SethTisue commented Mar 14, 2024

@lrytz should, could you provide a link to a sample artifact for @unkarjedy to test...?

@SethTisue SethTisue added release-notes worth highlighting in next release notes prio:hi high priority (used only by core team, only near release time) labels Mar 14, 2024
@lrytz
Copy link
Member Author

lrytz commented Mar 14, 2024

@unkarjedy Scala version 2.13.14-bin-ed3dfc9-SNAPSHOT on resolver https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots if that helps?

➜ sandbox unzip -l $(cs fetch --sources -r=https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots org.scala-lang:scala-library:2.13.14-bin-ed3dfc9-SNAPSHOT) | grep Any.scala
     7268  01-01-2010 00:00   scala/Any.scala

@unkarjedy
Copy link
Contributor

I was on a vacation.
I will take a look at this this week.

@unkarjedy
Copy link
Contributor

unkarjedy commented Apr 2, 2024

@lrytz It works :)

image image

@unkarjedy
Copy link
Contributor

unkarjedy commented Apr 2, 2024

I want to use some Scala versions in tests now, while Scala 2.13.14 is not yet published.
Can I rely that this artifact won't be removed from the Artifactory?

Scala version 2.13.14-bin-ed3dfc9-SNAPSHOT on resolver https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots if that helps?

@lrytz
Copy link
Member Author

lrytz commented Apr 2, 2024

We clean up old (> 2 years) artifacts there from time to time.

@unkarjedy
Copy link
Contributor

That suites us.
The version will be updated to 2.13.14 once it's released

@SethTisue SethTisue merged commit 0bc6ad5 into scala:2.13.x Apr 8, 2024
3 checks passed
@SethTisue SethTisue removed prio:hi high priority (used only by core team, only near release time) release-notes worth highlighting in next release notes labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants