Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform should take into account the targetTriple #2987

Closed
lolgab opened this issue Nov 11, 2022 · 2 comments · Fixed by #3002 or #3258
Closed

Platform should take into account the targetTriple #2987

lolgab opened this issue Nov 11, 2022 · 2 comments · Fixed by #3002 or #3258

Comments

@lolgab
Copy link
Contributor

lolgab commented Nov 11, 2022

When cross-compiling to a different operative system, the Platform defined here is not a constant but depends on the target triple we are compiling to.
If the target triple is set to "x86_64-windows-gnu" I expect Platform.isWindows to be true.
@armanbilge
Copy link
Member

See discussion / proposed solution in:

LeeTibbert added a commit to LeeTibbert/scala-native-fork that referenced this issue Nov 19, 2022
@LeeTibbert
Fix scala-native#2987: Inet6Address#toString will now try to convert …
cc51207 
…numeric zone ids to zone interface names
@LeeTibbert LeeTibbert mentioned this issue Nov 19, 2022
Merged
WojciechMazur pushed a commit that referenced this issue Nov 23, 2022
@LeeTibbert
Fix #2987: j.n.Inet6Address#toString now handles interface names (#3002)
ecc029d 
* Fix #2987: Inet6Address#toString will now try to convert numeric zone ids to zone interface names

* Pay obeisance to Windows
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this issue Nov 23, 2022
@LeeTibbert @WojciechMazur
Fix scala-native#2987: j.n.Inet6Address#toString now handles interfac…
0ce9cfa 
…e names (scala-native#3002)

* Fix scala-native#2987: Inet6Address#toString will now try to convert numeric zone ids to zone interface names

* Pay obeisance to Windows

(cherry picked from commit ecc029d)
@lolgab
Copy link
Contributor Author

lolgab commented Nov 23, 2022

I think this issue was closed by mistake @WojciechMazur

@WojciechMazur WojciechMazur reopened this Nov 23, 2022
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this issue Nov 23, 2022
@LeeTibbert @WojciechMazur
Fix scala-native#2987: j.n.Inet6Address#toString now handles interfac…
152db85 
…e names (scala-native#3002)

* Fix scala-native#2987: Inet6Address#toString will now try to convert numeric zone ids to zone interface names

* Pay obeisance to Windows

(cherry picked from commit ecc029d)
WojciechMazur pushed a commit that referenced this issue Nov 24, 2022
@LeeTibbert @WojciechMazur
Fix #2987: j.n.Inet6Address#toString now handles interface names (#3002)
9f57f0b 
* Fix #2987: Inet6Address#toString will now try to convert numeric zone ids to zone interface names

* Pay obeisance to Windows

(cherry picked from commit ecc029d)
@armanbilge armanbilge mentioned this issue Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@armanbilge @lolgab @WojciechMazur