Fixes to usage of structural types in Scala 3 #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 29, 2022
* Add reproducer for scala-native#2715 * Don't cast arguments of proxies if they already have correct type or when formal tyepe is primitive kind * Fix generation of reflective proxy to handle structural types using boxed types * Cleanup double definition in test
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 29, 2022
* Add reproducer for scala-native#2715 * Don't cast arguments of proxies if they already have correct type or when formal tyepe is primitive kind * Fix generation of reflective proxy to handle structural types using boxed types * Cleanup double definition in test
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Aug 31, 2022
* Add reproducer for scala-native#2715 * Don't cast arguments of proxies if they already have correct type or when formal tyepe is primitive kind * Fix generation of reflective proxy to handle structural types using boxed types * Cleanup double definition in test
WojciechMazur
added a commit
that referenced
this pull request
Sep 1, 2022
* Add reproducer for #2715 * Don't cast arguments of proxies if they already have correct type or when formal tyepe is primitive kind * Fix generation of reflective proxy to handle structural types using boxed types * Cleanup double definition in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715
The fix involves skipping the casting of the arguments when it's not needed.
On top of fixes according to correct handling of primitive types, additional fixes to handling proxies using boxed types were added. It is needed to handle Scala 3 reflective access using selectable fully. Previously proxy types assumed target arguments should always be unboxed, this is however incorrect in Scala 3.