Fix #3131: javalib ServerSocket should now be more accepting #3140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3131
javalib
java.net.ServerSocket#accept
now accepts new connections withoutthe cast errors.
Collaboration
User devlam, the author of PR #3131, deserves "co-authored-by" recognition for the
precise localization & reproducing code provided in that PR.
Of course, all bugs remain "authored-by" user LeeTibbert.
Backport
This PR is a candidate for backport to the SN 0.4.x series. I believe/hope it
will backport cleanly. I checked the dates for the IPv6 backport to the SN 0.4.x series and
these changes are relevant to 0.4.x.
Later: I have not been able to get a private baseline (pre-changes of this PR) SN 0.4.x out-of-the-box
Scala 3.2.2, Java 8 build to work after several hours invested. I'll try again if/when my patience recovers.
Given that network code is notorious for being difficult to backport, I will be
trying a private build whilst this PR is in CI.
Later yet: I got a baseline SN 0.4.x out-of-the-box build to work and tried to apply
the` fixes in this PR. Using only the one file with the effective change
caused compilation errors due to differences in 0.4.x.
Testing:
This PR has been manually tested with both IPv6 & IPv4 connections and passes.
scripted-test
java-net-server-socket
is intended to exerciseaccept()
but appearstotally non-functional; see Issue #3139.