Fix performance issue of MappedByteBuffers
#3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize and unsigned.USize
… cast to/from Short
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 4, 2023
* Optimize `java.nio.ByteArrayBits` to not allocate intermidiete tuples * Hint inlining of ByteArrayBits * Add Character.reverseBytes implementaiton * Sync templates with code generated types in runtime.Arrays , unsafe.Size and unsigned.USize * Handle CFuncPtr.apply when inlined
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 13, 2023
* Optimize `java.nio.ByteArrayBits` to not allocate intermidiete tuples * Hint inlining of ByteArrayBits * Add Character.reverseBytes implementaiton * Sync templates with code generated types in runtime.Arrays , unsafe.Size and unsigned.USize * Handle CFuncPtr.apply when inlined (cherry picked from commit adcad38)
WojciechMazur
added a commit
that referenced
this pull request
Oct 13, 2023
* Optimize `java.nio.ByteArrayBits` to not allocate intermidiete tuples * Hint inlining of ByteArrayBits * Add Character.reverseBytes implementaiton * Sync templates with code generated types in runtime.Arrays , unsafe.Size and unsigned.USize * Handle CFuncPtr.apply when inlined (cherry picked from commit adcad38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3414 which was suffering mostly due to unnecessary GC allocations.
Previously reading 32MB of data using FloatBuffer was taking ~3s in debug mode, now it's ~250ms and ~14ms in releaseMode. It now gets similar performance characteristics as on the JVM ~10-15ms