Faster unsafe.Ptr.{apply, update} by skipping unnecessary GC allocations
#3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
added a commit
to WojciechMazur/scala-native
that referenced
this pull request
Oct 13, 2023
…ala-native#3522) (cherry picked from commit ee84995)
WojciechMazur
added a commit
that referenced
this pull request
Oct 13, 2023
) (cherry picked from commit ee84995)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements Ptr appply/update methods to new create a new Ptr instance. In benchmarks made for #3521 from before rewrite of ByteArrayBits skipping GC allocations allowed to drop execution time from ~500ms to ~17ms when running in release-fast mode + lto=full
This change does also add additional
def {+,-}(offset: Int): Ptr[T]methods allowing to skip unneccessary boxing of primitive int to sized numbers