Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support current Scala 2.12 #131

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

ScalaWilliam
Copy link
Contributor

@ScalaWilliam ScalaWilliam commented Oct 4, 2017

I wanted to be able to use records in one project of mine that uses 2.12.3

  • Remove 2.12.0-RC1 instances; include 2.12.{0..3}
  • Add an explicit sbt version of 0.13.16 since this doesn't run with new sbt 1.0 which no longer has features used by this build.

@ScalaWilliam
Copy link
Contributor Author

Looks like build failed due to a network timeout.

Copy link
Contributor

@vjovanov vjovanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resolvers += Resolver.sonatypeRepo("snapshots"),
libraryDependencies += {
if (scalaVersion.value == "2.12.0-SNAPSHOT")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vjovanov
Copy link
Contributor

vjovanov commented Oct 5, 2017

Yep, I have restarted the build. We should remove support for JDK 6 to reduce load on the builders and reduce the probability for transient failures.

@@ -0,0 +1 @@
sbt.version=0.13.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to set the editor to add an end of line before the end of file automatically.

@vjovanov vjovanov merged commit a872170 into scala-records:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants