Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: show (transitive) impact of bumps across modules #2520

Open
bjaglin opened this issue Feb 10, 2022 · 1 comment
Open

Feature idea: show (transitive) impact of bumps across modules #2520

bjaglin opened this issue Feb 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bjaglin
Copy link
Contributor

bjaglin commented Feb 10, 2022

Rationale

To be able to see which modules are impacted by a Steward PR and how transitive dependencies are affected, it would be interesting to append a diff of the dependencies across modules in the PR description.

Implementation

The initial implementation could rely on recent versions of sbt and consists in doing a diff on something like +Compile / dependencyList; +Test / dependencyList (after injecting a addDependencyTreePlugin in the meta-build and the meta-meta-build) before and after the edits. Since the output is quite verbose for multi-module projects and it would introduce a significant overhead since sbt needs to be reloaded, this should probably be an opt-in.

The description of scalacenter/scalafix#1533 was manually edited to include what the diff could look like (I diffed only 2 modules and naively processed the output manually).

Challenges

  • the size of the diff may exceed the maximum size of a PR description - just fallback to a description without diff in that case?
  • filter out self-reference in dependencyList (present only when publishing is enabled?) so that untouched modules don't produce a diff
  • filter out intra-project module references since it's just noise?
@exoego exoego added the enhancement New feature or request label Feb 10, 2022
@bjaglin
Copy link
Contributor Author

bjaglin commented Feb 10, 2022

cc @github-sebastien-boulet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants