Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add a warning emoji (⚠️) for any major version updates #2873

Closed
eed3si9n opened this issue Jan 2, 2023 · 0 comments · Fixed by #2986
Closed

feature request: add a warning emoji (⚠️) for any major version updates #2873

eed3si9n opened this issue Jan 2, 2023 · 0 comments · Fixed by #2986
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eed3si9n
Copy link
Contributor

eed3si9n commented Jan 2, 2023

Major version updates of the dependencies can have unintended consequences that are time-consuming to reverse and/or fix-forward.

Some recent examples are scala-xml 2.x and slf4j 2.x, both affecting sbt 1.x plugin/build ecosystem. See for example coursier/sbt-coursier#422
In theory, all automatic PRs should be carefully reviewed. But I think people hit merge, trusting that Scala Steward is making the right call.

I wonder if we could add a warning emoji (⚠️) and a note in the PR calling for the attention of the reviewer that they might be cause a downstream "dependency hell"/diamond problem if they hit the merge button.

@exoego exoego added enhancement New feature or request good first issue Good for newcomers labels Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants