Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message in case git or scalafmt is not on the path #1897

Merged

Conversation

robstoll
Copy link
Contributor

incorporates the feedback of #1890

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1897 (a5f9a1d) into master (8701a6d) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1897   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files         129      129           
  Lines        2213     2213           
  Branches       61       61           
=======================================
  Hits         1728     1728           
  Misses        485      485           
Impacted Files Coverage Δ
...g/scalasteward/core/application/SelfCheckAlg.scala 84.61% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8701a6d...a5f9a1d. Read the comment docs.

Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @robstoll!

@fthomas fthomas added this to the 0.9.0 milestone Jan 19, 2021
@fthomas fthomas added the enhancement New feature or request label Jan 19, 2021
@fthomas fthomas merged commit 6e01b11 into scala-steward-org:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants