Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default implementation for BuildToolAlg#runMigration #3244

Merged
merged 1 commit into from Dec 14, 2023

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Dec 13, 2023

This adds a default implementation for BuildToolAlg#runMigration that logs a warning that Scalafix migrations are not supported by the build tool. It saves some repeated text that is used for every build tool except sbt.

This adds a default implementation for `BuildToolAlg#runMigration` that
logs a warning that Scalafix migrations are not supported by the build
tool. It prevents some repeated text that is used for every build tool
except sbt.
@fthomas fthomas added this to the 0.29.0 milestone Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (29dcd58) 91.23% compared to head (6998d77) 91.26%.

Files Patch % Lines
...org/scalasteward/core/buildtool/BuildToolAlg.scala 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
+ Coverage   91.23%   91.26%   +0.03%     
==========================================
  Files         164      165       +1     
  Lines        3398     3402       +4     
  Branches      301      310       +9     
==========================================
+ Hits         3100     3105       +5     
+ Misses        298      297       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes a sense to me

@fthomas fthomas merged commit 986b845 into main Dec 14, 2023
9 of 10 checks passed
@fthomas fthomas deleted the topic/default-runMigration branch December 14, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants