Handle Scala LTS and Next version updates #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala Steward now distinguishes between Scala Next and Scala LTS. When the current Scala 3 versions is below 3.4.0 no updates to a newer Scala Next version will be created. But updates to newer Scala 3.3.x version will be created. If the current version is already a Scala Next version (3.4.x), updates to newer Scala Next versions will be created. In the future the `versionLine` property can be used to identify LTS and Next version. (scala/scala3#19986)
mzuehlke
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3328 +/- ##
=======================================
Coverage 91.18% 91.19%
=======================================
Files 166 166
Lines 3404 3419 +15
Branches 317 287 -30
=======================================
+ Hits 3104 3118 +14
- Misses 300 301 +1 ☔ View full report in Codecov by Sentry. |
|
Looks like this is not working as intended (anymore): playframework/play-json#1035 (comment), maybe #3347 broke things? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala Steward now distinguishes between Scala Next and Scala LTS.
When the current Scala 3 versions is below 3.4.0 no updates to a newer Scala Next version will be created. But updates to newer Scala 3.3.x version will be created.
If the current version is already a Scala Next version (3.4.x), updates to newer Scala Next versions will be created.
In the future the
versionLineproperty can be used to identify LTS and Next version. (scala/scala3#19986)fixes: #3302
followup to: #3323
I am bit unsure if I should release the changes to
default.scala-steward.conflater, after cutting a new release and a bit of wait time, as otherwise older versions would again create pull-requests for Scala 3.4.1. But that probably has already happened in most cases.