Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala3-compiler, scala3-library, ... 3.4.1 (was 3.3.3) #1035

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates

from 3.3.3 to 3.4.1

📜 GitHub Release Notes - Version Diff - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@mergify mergify bot added the type:updates label May 8, 2024
@mkurz
Copy link
Member

mkurz commented May 8, 2024

@mzuehlke do you know why scala steward wants to upgrade to Scala 3.4 here? I thought that should not happen if we are on a LTS according to:

Or did I miss something?

Or wait..
Looking at https://github.com/scala-steward-org/scala-steward/blob/52719d73f6715c2747a250092bd51cb82f069cae/modules/core/src/main/resources/default.scala-steward.conf#L33-L46

  // Ignore the next Scala 3 Next version until it is announced.
  { groupId = "org.scala-lang", artifactId = "scala3-compiler",     version = { exact = "3.4.2" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library",      version = { exact = "3.4.2" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.2" } },

  // Ignore the next Scala 3 LTS version until it is announced.
  { groupId = "org.scala-lang", artifactId = "scala3-compiler",     version = { exact = "3.3.4" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library",      version = { exact = "3.3.4" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.4" } },

  // Ignore the 3.3.2 version as it is abandoned due to broken compatibility
  { groupId = "org.scala-lang", artifactId = "scala3-compiler",     version = { exact = "3.3.2" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library",      version = { exact = "3.3.2" } },
  { groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.2" } },

Do we need to add exact = "3.4.1" and exact = "3.4.0" also?

Thanks!

@mkurz
Copy link
Member

mkurz commented May 8, 2024

Should be fixed with

@mkurz mkurz closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants