Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original Yrecursion tests progressed #12914

Closed
ghost opened this issue Nov 26, 2023 · 4 comments · Fixed by scala/scala#10614
Closed

Original Yrecursion tests progressed #12914

ghost opened this issue Nov 26, 2023 · 4 comments · Fixed by scala/scala#10614

Comments

@ghost
Copy link

ghost commented Nov 26, 2023

No description provided.

@SethTisue
Copy link
Member

SethTisue commented Nov 26, 2023

The test case in question dates back to 2008. Without -Yrecursion 1, It fails to compile in Scala 2.7.7, but succeeds in Scala 2.8.2 and other subsequent Scala 2 versions.

(On Scala 3 it doesn't compile at all because it uses # on an abstract type, which the language no longer permits.)

A pull request removing -Yrecursion 1 from the test would be welcome, afaics. Adding a new test case that does require -Yrecursion 1 in order to compile would be welcome as well.

@SethTisue
Copy link
Member

SethTisue commented Nov 26, 2023

Why(!) is -Yrecursion not needed anymore for this test-case?

We don't know — and probably never will. It was so long ago that doing the necessary archaeology to answer that would be rather difficult.

We routinely use git bisect to identify the particular PR when something progressed or regressed, if we care enough about the issue in question, but we can only reasonably (as in, without substantial extra effort) go back a certain number of years that way, and Scala 2.7 and 2.8 are now outside of that window.

@som-snytt
Copy link

That's a good one. I've wanted a partest option to "fuzz" test options. Sometimes I'll write a test with -Xlint but it's not part of the test, only to lint the test code.

@som-snytt
Copy link

som-snytt commented Nov 27, 2023

other history ancient and modern which demonstrates the long haul of cyclic aliasing.
#8252

showing sometimes there is a reply from on high that does not answer our prayers
#11963

(Edit: the latter was an illustration for any concerned interlopers of a question going unanswered [because there is no answer] and a polite appeal to powers that be, which elicited a response of a sort.)

@ghost ghost changed the title test proj-rec-test.scala tests for success (but should test for failure) void Nov 28, 2023
@som-snytt som-snytt changed the title void Original Yrecursion tests progressed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants