Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASTy reader should support Scala 3.4 #12932

Closed
SethTisue opened this issue Jan 22, 2024 · 2 comments · Fixed by scala/scala#10670
Closed

TASTy reader should support Scala 3.4 #12932

SethTisue opened this issue Jan 22, 2024 · 2 comments · Fixed by scala/scala#10670
Assignees
Labels
Milestone

Comments

@SethTisue
Copy link
Member

@bishabosha now that 3.4 seems like it could be imminent (3.4.0-RC2 is on Maven Central), could you make sure that the Scala 2 TASTy reader supports it...? We'd like to ship Scala 2.13.13 with 3.4 support in the TASTy reader.

@SethTisue SethTisue added this to the 2.13.13 milestone Jan 22, 2024
@bishabosha
Copy link
Member

On it!

@bishabosha
Copy link
Member

bishabosha commented Jan 23, 2024

Point of discussion here: 3.4.x is going to be laying the groundwork for Zinc pipelining support in Scala 3. That means a Scala 2 build with pipelining turned on is going to only see TASTy files on the classpath from an upstream Scala 3 project. This means that the current way of looking for the TASTY attribute in a classfile isn't going to work (there will be no classfiles).

So if we want to seriously support pipelining then we will need to make deeper cuts in the Scala 2 compiler to change classpath scanning to account for these TASTy only cases - see scala/scala3#17594

See scala/scala#10670 for an implementation that seems to work (mixing directory and jar classpaths)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants