Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit JVM InnerClasses attribute for bean info classes #5983

Closed
scabug opened this issue Jun 26, 2012 · 3 comments
Closed

emit JVM InnerClasses attribute for bean info classes #5983

scabug opened this issue Jun 26, 2012 · 3 comments

Comments

@scabug
Copy link

scabug commented Jun 26, 2012

Discussion (mostly about how to unearth a stack trace) at
https://groups.google.com/d/topic/scala-internals/XTVeVEsQcGc/discussion

Initial pull request at scala/scala#768

@scabug
Copy link
Author

scabug commented Jun 26, 2012

Imported From: https://issues.scala-lang.org/browse/SI-5983?orig=1
Reporter: @magarciaEPFL
Assignee: @magarciaEPFL
See #5985

@scabug
Copy link
Author

scabug commented Jun 26, 2012

@magarciaEPFL said:
Fixed for GenASM in 3bd646bb2fd8512dcfa14fd7941dafe955fda5ee .

Leaving open till corresponding fix lands in GenJVM, or GenJVM is deprecated, whatever happens first.

Example comparing with and without fix:

class Outer {

  class IA

  class IB

  @scala.beans.BeanInfo
  case class B(a: IA, b: IB)

}

javap for GenASM output (-target:jvm-1.6) (similar results with -target:jvm-1.5-asm)

// Including_InnerClasses_Attribute.javap
public class Outer$BBeanInfo extends scala.beans.ScalaBeanInfo
  SourceFile: "bt4.scala"
  InnerClass: 
   public #64= #9 of #63; //B=class Outer$B of class Outer
  minor version: 0
  major version: 50
  Constant pool:
. . . 

javap for GenJVM output (-target:jvm-1.5)

// Missing_InnerClasses_Attribute.javap
public class Outer$BBeanInfo extends scala.beans.ScalaBeanInfo
  SourceFile: "bt4.scala"
  minor version: 0
  major version: 49
  Constant pool:
. . . 

@scabug
Copy link
Author

scabug commented Jun 27, 2012

@magarciaEPFL said:
Once #5985 allows partest to check javap or ASM Textifier output, a test can be provided for this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant