Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quasiquote's use ListMap for position handling might be erroneous #8285

Closed
scabug opened this issue Feb 14, 2014 · 3 comments
Closed

Quasiquote's use ListMap for position handling might be erroneous #8285

scabug opened this issue Feb 14, 2014 · 3 comments
Assignees
@densh
Labels
has PR quasiquotes reflection
Milestone
2.11.0-RC3

Comments

@scabug
Copy link

scabug commented Feb 14, 2014

It's possible that usage of ListMap for posMap in quasiquotes is not appropriate and might cause ordering problems.

https://github.com/scala/scala/blob/master/src/compiler/scala/tools/reflect/quasiquotes/Placeholders.scala#L20

This question needs more investigation and additional testing of positioning of errors in situations with 10+ unquotations.
@scabug
Copy link
Author

scabug commented Feb 14, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8285?orig=1
Reporter: @densh
Affected Versions: 2.11.0-RC1

@scabug
Copy link
Author

scabug commented Feb 24, 2014

@densh said:
Fixed in densh/scala@9058cad.

@scabug
Copy link
Author

scabug commented Feb 28, 2014

@densh said:
scala/scala#3593

@scabug scabug closed this as completed Mar 1, 2014
@scabug scabug added this to the 2.11.0-RC3 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@densh densh

Labels
has PR quasiquotes reflection
Projects
None yet
Milestone
2.11.0-RC3
Development

No branches or pull requests
2 participants
@densh @scabug