Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Re-add (deprecated?) collection.Seq.updated? #549

Closed
lrytz opened this issue Apr 4, 2018 · 2 comments
Closed

Re-add (deprecated?) collection.Seq.updated? #549

lrytz opened this issue Apr 4, 2018 · 2 comments
Assignees
@julienrf
Labels
in progress
Milestone
Scala 2.13.0-M4

Comments

@lrytz
Copy link
Member

lrytz commented Apr 4, 2018

Can work around with collection.Seq(1).patch(0, List(2), 1)...

Once fixed, revert fix TODO-newColl in test/files/run/t5328.scala.
@lrytz lrytz changed the title Re-add deprecated collection.Seq.updated? Re-add (deprecated?) collection.Seq.updated? Apr 4, 2018
@Atry Atry mentioned this issue Apr 11, 2018
Merged
@szeiger
Copy link
Member

szeiger commented Apr 12, 2018

This is similar to methods like + that build a new collection but could easily mistaken for in-place updates and are therefore only defined (and not deprecated) for immutable collections. We should consider deprecating collection.Seq.updated as well.

@szeiger szeiger added this to the Scala 2.13.0-M4 milestone Apr 19, 2018
@julienrf
Copy link
Contributor

@szeiger We eventually pulled the +: and :+ operations of collection.immutable.Seq to collection.Seq, without deprecating them.

julienrf added a commit to julienrf/scala that referenced this issue Apr 20, 2018
@julienrf
Add a deprecated updated operation to collection.Seq
c4b2288 
Fix scala/collection-strawman#549
@julienrf julienrf self-assigned this Apr 20, 2018
@julienrf julienrf mentioned this issue Apr 20, 2018
Merged
julienrf added a commit to julienrf/scala that referenced this issue May 13, 2018
@julienrf
Add back the updated operation to collection.Seq
a249502 
Fix scala/collection-strawman#549
julienrf added a commit to julienrf/scala that referenced this issue May 13, 2018
@julienrf
Add back the updated operation to collection.Seq
c5d40a0 
Fix scala/collection-strawman#549
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@julienrf julienrf

Labels
in progress
Projects
None yet
Milestone
Scala 2.13.0-M4
Development

No branches or pull requests
3 participants
@szeiger @lrytz @julienrf