Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Drop Scala 2.12.x support #113

Closed
wants to merge 1 commit into from
Closed

Drop Scala 2.12.x support #113

wants to merge 1 commit into from

Conversation

julienrf
Copy link
Contributor

This lets us remove some type annotations in the tests.

In the memoryBenchmarks project I now use json4s instead of jawn to produce JSON, because jawn is not yet compatible with 2.13.

@szeiger
Copy link
Member

szeiger commented Jun 15, 2017

I'll update scala/scala#5742 for 2.13 (to be backported to 2.12 later if it doesn't cause any problems in 2.13). Let's wait before we have have 2.13.0-M2 with this fix, otherwise most type errors blow up the compiler instead of giving a proper error message.

@odersky
Copy link
Contributor

odersky commented Jun 16, 2017

I'd like to review this but can only do it after PLDI. So it will be probably a week until you have the review. Thanks for holding that long...

@Ichoran
Copy link
Contributor

Ichoran commented Jun 17, 2017

I'm wary of dropping 2.12 support so early given that there may be a number of external libraries that could be useful to us for testing, benchmarking, and so on. On the other hand, we do need to test the syntax as it will be in 2.13, so maybe we can't hold off any longer.

As far as the changes themselves go, LGTM.

@SethTisue
Copy link
Member

SethTisue commented Dec 14, 2017

I have now dropped this repo from the Scala 2.12 community build (as per #320)

@szeiger szeiger added the not scala/scala Not relevant for moving to scala/scala label Mar 12, 2018
@julienrf
Copy link
Contributor Author

The last release that supported 2.12 was 0.9.0. Then the code moved to the scala/scala repository. From now on, the changes will be available in 2.13 only.

@julienrf julienrf closed this Apr 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
not scala/scala Not relevant for moving to scala/scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants