Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Akka HTTP and Akka Streams #146

Closed
SethTisue opened this issue Oct 26, 2015 · 9 comments · Fixed by #298
Closed

add Akka HTTP and Akka Streams #146

SethTisue opened this issue Oct 26, 2015 · 9 comments · Fixed by #298
Assignees

Comments

@SethTisue
Copy link
Member

we should do this because it's Akka, but also because ensime-server's master branch now has them as a dependency

I tried changing our dep to akka.git#releasing-akka-stream-and-http-experimental-1.0 but it didn't work and I decided to postpone rather than investigate. (for now we freeze ensime-server at the commit before the dependency was added)

(this was in the 2.11 build. it might be better to leave that one alone and only tackle Akka Streams in Java 8 world? dunno)

@SethTisue
Copy link
Member Author

SethTisue commented Aug 23, 2016

it might be better to leave that one alone and only tackle Akka Streams in Java 8 world

definitely only worth tackling on JDK 8. the JDK 6 community build is pretty close to frozen these days; too many libs are dropping JDK 6 support, and the existing set is good enough to achieve our main goal of guarding against regressions in Scala 2.11.x

@SethTisue
Copy link
Member Author

depends on #292

@SethTisue
Copy link
Member Author

wip in SethTisue/community-builds#akka-http:

[akka-http] [error] /Users/tisue/community-builds.212/target-0.9.5/project-builds/akka-http-2993527e43e49e6d7b8326a319451cfd3000db8b/akka-stream/src/main/scala/akka/stream/javadsl/Source.scala:159: illegal inheritance from final class Inclusive
[akka-http] [error]         new Inclusive(start, end, step) {
[akka-http] [error]             ^
[akka-http] [error] one error found

@SethTisue
Copy link
Member Author

SethTisue commented Sep 23, 2016

this is an actual incompatibility with Scala 2.12, because Range.Inclusive is final since scala/scala#5226

@ktoso can you guys work around this? in general, subclassing collections is iffy

@som-snytt
Copy link

Also, Range got a compact toString at scala/scala@214ea82

@SethTisue
Copy link
Member Author

SethTisue commented Sep 23, 2016

in the above test runs I was trying an approach of building Akka in two separate phases, first with most of the modules, then again with akka-http + akka-stream. the first phase produced an akka-actors jar for ssl-config to depend on. that part worked, but akka-http-core failed to build, with dbuild/sbt saying it couldn't find the akka-testkit and/or akka-stream-testkit modules. I guess it has to do with test dependencies vs. regular dependencies somehow. I tried tweaking the projects and exclude lists in various ways but didn't succeed in making the errors go away.

currently trying again with a slightly different approach: in the first phase, only publish akka-actor, which is all ssl-config needs. then build everything else in the second phase. I have high hopes this will work

SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2016
also adds akka-cluster, akka-remote-tests, ssl-config

fixes scala#146, fixes scala#292
@SethTisue
Copy link
Member Author

SethTisue commented Sep 23, 2016

latest attempt fails with a Scaladoc generation issue; reported upstream at akka/akka#21543

SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2016
also adds akka-cluster, akka-remote-tests, ssl-config

fixes scala#146, fixes scala#292
SethTisue added a commit to SethTisue/community-build that referenced this issue Sep 23, 2016
also adds akka-cluster, akka-remote-tests, ssl-config

fixes scala#146, fixes scala#292
@SethTisue
Copy link
Member Author

done in #298 , but I had to fork akka to get the needed Range.Inclusive change in. reported upstream at akka/akka#21548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants