Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.12: new Scala SHA #1097

Merged
merged 4 commits into from Mar 1, 2020
Merged

Conversation

@SethTisue SethTisue added the contents label Feb 26, 2020
@SethTisue SethTisue self-assigned this Feb 26, 2020
@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 27, 2020

scalariform tests failing: scala/scala#8466 (comment)

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 27, 2020

scalariform thing now has its own ticket, milestoned 2.12.11: scala/scala-dev#672

some more 2.12.x PRs were merged today, so I've bumped the SHA again and queued another run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/5536/ fyi @lrytz

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 28, 2020

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 28, 2020

I will dig into this a bit and once I know a bit more, I will open one or more scala-dev tickets on the 2.12.11 milestone

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 28, 2020

scalikejdbc failure is reproducible outside dbuild (on scalikejdbc/scalikejdbc@12b8f45) with core/testOnly *ResultSetTraversableSpec. bisecting shows that it regressed in scala/scala#8732 (2.12.11-bin-ab4d97e)

scalafix failure is really hard to reproduce outside of dbuild. the scalafix commit we build is on 2.12.6, not 2.12.10, and there are multiple uses of CrossVersion.full in the build. I spent about an hour on it before deciding the rabbit hole is too deep. (in case we end up down the hole again, I pushed my wip to a seth-20200228 branch in SethTisue/scalafix, branched off their v0.9.9 tag which is on 2.12.10 but, who knows, might not even be a point in time where the problem is reproducible at all); reflect/update fails for reasons I don't understand).

I suggest we fix whatever bug is affecting scalikejdbc, then hope that fixes scalafix as well. and if it doesn't, we either go back down the rabbit hole, or we use dbuild for scalafix testing. the problem with the latter is that scalafix sits atop a tall pile of dependencies that take a long time to build.

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 29, 2020

I did a series of runs on a subset of the community build that verified that scalafix regressed in the same PR that scalikejdbc did, so I'm pretty confident that scala/scala#8769 will fix the problem.

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 29, 2020

well, this is weird. the other repos are green, but now airframe is failing... I'll look into it

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/5553/artifact/logs/airframe-build.log

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 29, 2020

In local testing, the test also fails on 2.12.10 and 2.13.1. I hypothesize this is related to today/yesterday being a leap day.

and sure enough, I looked at the source code for the test, and:

  def `succinct time window unit`: Unit = {
    // 2020 have 366 days, so we need to fix the offset
    val t = TimeWindow.withUTC.withOffset("2019-01-01 00:00:00")

(Also, I looked at the source code for TimeVector itself and it has nothing to do with scala.collection.immutable.Vector or with anything else in scala.collection, afaict.)

@SethTisue

This comment has been minimized.

Copy link
Member Author

SethTisue commented Feb 29, 2020

I merged the reversion PR and excluded the airframe test (and reported the problem upstream: wvlet/airframe#953). I'll start a new run as soon as Travis-CI finishes building our new RC (2.12.11-bin-d1e9ac0)

@SethTisue

This comment has been minimized.

@SethTisue SethTisue merged commit f6266b7 into scala:2.12.x Mar 1, 2020
@SethTisue SethTisue deleted the SethTisue:new-scala-2.12-sha-20200226 branch Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.