Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to cats (and cats-effect) 2.2.0 and cats-mtl 1.0 #1231

Merged
merged 28 commits into from Oct 9, 2020
Merged

move to cats (and cats-effect) 2.2.0 and cats-mtl 1.0 #1231

merged 28 commits into from Oct 9, 2020

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Sep 30, 2020 •
edited

@SethTisue SethTisue self-assigned this Sep 30, 2020
@SethTisue SethTisue mentioned this pull request Sep 30, 2020
Merged
@SethTisue SethTisue changed the title unfork refined, then refork with fewer changes unfork refined Oct 1, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Oct 1, 2020 •
edited

latest refined expects cats 2.2.0. I'm experimenting with expanding the scope of this PR to include that upgrade. (so far, I've found it requires replacing simulacrum with simulacrum-scalafix, and adding discipline-munit.)

@SethTisue SethTisue marked this pull request as draft October 1, 2020 21:09
@SethTisue SethTisue changed the title unfork refined move to cats 2.2.0 Oct 1, 2020
@SethTisue SethTisue changed the title move to cats 2.2.0 move to cats (and cats-effect) 2.2.0 Oct 1, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Oct 1, 2020 •
edited

circe hasn't upgraded. I get the same compile errors that we also see at circe/circe#1529

there are a few other failures but I think circe is the blocker here

@SethTisue
Copy link
Member Author

I'm just going to close this for now. Will surely return to it later.

@travisbrown Is the 2.2 upgrade a priority for circe? Is it something we ought to look for a volunteer to tackle?

@travisbrown travisbrown mentioned this pull request Oct 3, 2020
Merged
@travisbrown
Copy link

@SethTisue It should just be a matter of updating without the Scalafix migrations from Scala Steward. I'm trying it now.

@SethTisue
Copy link
Member Author

I'll reopen once the linked PR lands.

@SethTisue SethTisue closed this Oct 6, 2020
@SethTisue SethTisue reopened this Oct 7, 2020
@SethTisue SethTisue mentioned this pull request Oct 8, 2020
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Oct 8, 2020 •
edited

circe is green now 👍

Good progress here. Working on dealing with some other failures downstream. I may need to open some tickets requesting that downstream maintainers upgrade.

@SethTisue SethTisue mentioned this pull request Oct 9, 2020
Merged
@SethTisue SethTisue changed the title move to cats (and cats-effect) 2.2.0 move to cats (and cats-effect) 2.2.0 and cats-mtl 1.0 (removing meow-mtl and pfps-shopping-cart for now) Oct 9, 2020
@SethTisue SethTisue marked this pull request as ready for review October 9, 2020 20:45
@SethTisue SethTisue changed the title move to cats (and cats-effect) 2.2.0 and cats-mtl 1.0 (removing meow-mtl and pfps-shopping-cart for now) move to cats (and cats-effect) 2.2.0 and cats-mtl 1.0 Oct 9, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Oct 9, 2020 •
edited

@oleg-py I'll have to remove meow-mtl for now, pending resolution of oleg-py/meow-mtl#18

@gvolpe and with meow-mtl out, pfps-shopping-cart is out too — but I'm eager to re-add them both once doing so becomes possible again

@SethTisue SethTisue merged commit 449a2aa into scala:2.13.x Oct 9, 2020
@SethTisue SethTisue deleted the unfork-refork-refined branch October 9, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SethTisue @travisbrown